feat!: remove eslint v8 / eslintrc support and remove flat/ prefix from configs#528
Conversation
This change removes support for legacy rc-based configs, and moves minimum supported version to 9.0. I've also removed the deprecated `/configs` entry point.
|
Can you cherry-pick my commit from this PR to include the RuleTester update? Then I can close my PR. |
|
Your PR removed our |
There was a problem hiding this comment.
Your PR removed our RuleTester, but with the vitest change (which I believe was still in PR, when your change went up), we still need to attach vitest's functions to RuleTester. So I removed the v8 specific logic from it, but left the vitest augmentation. I think this will cover what was in your change?
@michaelfaith I just pushed this change to solve that so rule test files can use the standard RuleTester import. Look good?
There was a problem hiding this comment.
Yep! That's much cleaner. Thanks.
bmish
changed the title
flat/ prefix from configs
There was a problem hiding this comment.
Here's some more context about the config names btw:
I think the current plan to just drop ESLint v8 / eslintrc now is fine.
| }, | ||
| ], | ||
| import eslintPlugin from 'eslint-plugin-eslint-plugin'; | ||
| import packageMetadata from './package.json' with { type: 'json' }; |
There was a problem hiding this comment.
Error: 130:29 error Can't resolve './package.json' in '/home/runner/work/eslint-plugin-eslint-plugin/eslint-plugin-eslint-plugin/docs/rules/require-meta-docs-url.md' n/no-missing-import
You can disable that lint rule for this file if necessary.
There was a problem hiding this comment.
Example of disabling a lint rule for markdown code sample:
There was a problem hiding this comment.
Ah, I had 'n/no-missing-imports' instead of 'n/no-missing-import' doh
There was a problem hiding this comment.
Looks good now
2 participants
This change removes support for legacy rc-based configs, and moves minimum supported version to 9.0. I've also removed the deprecated
/configsentry point. Please use the plugin'sconfigsobject.Contributes to #505